]> git.ipfire.org Git - thirdparty/libvirt.git/commit
qemu_migration_params: Avoid deadlock in qemuMigrationParamsReset v8.6.0-rc2
authorJiri Denemark <jdenemar@redhat.com>
Thu, 28 Jul 2022 13:35:45 +0000 (15:35 +0200)
committerJiri Denemark <jdenemar@redhat.com>
Fri, 29 Jul 2022 07:34:53 +0000 (09:34 +0200)
commit8cb19a9b9a56ab6ebefc1f913c545e0bb86d4364
treefe13e2f293eea21bd3643b0f88bb347611fcd0f5
parent640d185f01858b7a8db401235c929ac4798592d0
qemu_migration_params: Avoid deadlock in qemuMigrationParamsReset

In my recent comnmit v8.5.0-188-gc47f1abb81 I accidentally moved
qemuMigrationParamsResetTLS after qemuDomainObjEnterMonitorAsync not
noticing qemuMigrationParamsResetTLS will try to enter the monitor
again. The second call will time out and return with a domain object
locked. But we're still in monitor section and the object should be
unlocked which means qemuDomainObjExitMonitor will deadlock trying to
lock it again.

Fixes: c47f1abb81194461377a0c608a7ecd87f9ce9146
Signed-off-by: Jiri Denemark <jdenemar@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
src/qemu/qemu_migration_params.c