]> git.ipfire.org Git - thirdparty/postgresql.git/commit
Fix some confusing uses of const
authorPeter Eisentraut <peter@eisentraut.org>
Thu, 30 Oct 2025 09:44:36 +0000 (10:44 +0100)
committerPeter Eisentraut <peter@eisentraut.org>
Thu, 30 Oct 2025 10:20:04 +0000 (11:20 +0100)
commit8ce795fcb70df7a8fdf3303eec0cfcd703b0d122
treed931e44077408d6229c432a01e2b4a23746d7766
parent9fcd4874ed50ee6c60dadd0f1146d8fea9ff0055
Fix some confusing uses of const

There are a few places where we have

    typedef struct FooData { ... } FooData;
    typedef FooData *Foo;

and then function declarations with

    bar(const Foo x)

which isn't incorrect but probably meant

    bar(const FooData *x)

meaning that the thing x points to is immutable, not x itself.

This patch makes those changes where appropriate.  In one
case (execGrouping.c), the thing being pointed to was not immutable,
so in that case remove the const altogether, to avoid further
confusion.

Co-authored-by: Chao Li <li.evan.chao@gmail.com>
Discussion: https://www.postgresql.org/message-id/CAEoWx2m2E0xE8Kvbkv31ULh_E%2B5zph-WA_bEdv3UR9CLhw%2B3vg%40mail.gmail.com
Discussion: https://www.postgresql.org/message-id/CAEoWx2kTDz%3Db6T2xHX78vy_B_osDeCC5dcTCi9eG0vXHp5QpdQ%40mail.gmail.com
contrib/pg_surgery/heap_surgery.c
src/backend/access/gin/ginget.c
src/backend/access/gin/ginpostinglist.c
src/backend/executor/execGrouping.c
src/backend/nodes/tidbitmap.c
src/backend/utils/adt/tsvector_op.c
src/include/access/gin_private.h
src/include/nodes/tidbitmap.h
src/tools/pgindent/typedefs.list