]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
drm/bridge: add warning for bridges using neither devm_drm_bridge_alloc() nor drm_bri...
authorLuca Ceresoli <luca.ceresoli@bootlin.com>
Tue, 28 Oct 2025 10:15:46 +0000 (11:15 +0100)
committerLuca Ceresoli <luca.ceresoli@bootlin.com>
Mon, 3 Nov 2025 12:04:55 +0000 (13:04 +0100)
commit9347f2fbb0183b04070cd7dfde080bfcc54c0f7c
tree9e69eb6e3d1c048cf2a41f9e753d5cb7e2926eef
parent76f1a9711b837f90fba91d00e33549ed1364bea2
drm/bridge: add warning for bridges using neither devm_drm_bridge_alloc() nor drm_bridge_add()

The correct sequence for bridge initialization is:

 1. devm_drm_bridge_alloc()
 2. drm_bridge_add()
 3. drm_bridge_attach()

For bridges missing either 1 or 2 there are warnings in place already,
presenting an explanatory error message.

Bridges missing both 1 and 2 would still face a poorly understandable
message, as reported in a recent regression report [0]:

  WARNING: [...] at [...]/lib/refcount.c:25 drm_bridge_attach+0x2c/0x1dc
  ...
  Call trace:
  ...
   drm_bridge_attach
  ...

Add a new warning to ensure an understandable message is logged in such
cases. Use the same message and warning message already in place in
drm_bridge_add().

[0] https://lore.kernel.org/all/hlf4wdopapxnh4rekl5s3kvoi6egaga3lrjfbx6r223ar3txri@3ik53xw5idyh/

Reviewed-by: Maxime Ripard <mripard@kernel.org>
Link: https://patch.msgid.link/20251028-b4-drm-bridge-alloc-add-before-attach-v3-5-bb8611acbbfb@bootlin.com
Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
drivers/gpu/drm/drm_bridge.c