]> git.ipfire.org Git - thirdparty/libcgroup.git/commit
api.c: add precision to fscanf(), in cgroup_get_all_controller_next()
authorKamalesh Babulal <kamalesh.babulal@oracle.com>
Mon, 8 Aug 2022 16:36:16 +0000 (10:36 -0600)
committerTom Hromatka <tom.hromatka@oracle.com>
Mon, 8 Aug 2022 16:36:34 +0000 (10:36 -0600)
commit97aa5a67f9ed067a281cb77a06546ab09191064c
treed01be4b7ee752ddb8a431bb6ff5b701ac80b0698
parentc9426c2f548efbf3b41a5fdf2618614bd0c21dd9
api.c: add precision to fscanf(), in cgroup_get_all_controller_next()

Fix calling risky function warning, reported by Coverity tool:

CID 258300 (#1 of 1): Calling risky function
(DC.STREAM_BUFFER)dont_call: fscanf assumes an arbitrarily long string,
so callers must use correct precision specifiers or never use fscanf.

As per secure coding standard, using '%s' in the fscanf() is not
recommend, hence fix it by using the precision of macro
MAX_CGROUP_TYPE_NAMELEN borrowed from Linux Kernel for the maximum
allowed controller/subsys_name length.

Signed-off-by: Kamalesh Babulal <kamalesh.babulal@oracle.com>
Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com>
(cherry picked from commit 4036f4fe4334572a4669dfece01ff24dbdd56477)
src/api.c