]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
tcp: Fix potential UAF in reqsk_timer_handler().
authorKuniyuki Iwashima <kuniyu@google.com>
Wed, 6 May 2026 03:59:18 +0000 (03:59 +0000)
committerJakub Kicinski <kuba@kernel.org>
Fri, 8 May 2026 21:54:50 +0000 (14:54 -0700)
commit97c8a3c1f73d828de43a5a88e8a9a143efb2b661
treef91874ec81bb38efe2e2191fa7eac529b7c97b66
parentfcee7d82f27d6a8b1ddc5bbefda59b4e441e9bc0
tcp: Fix potential UAF in reqsk_timer_handler().

When TCP socket migration fails at inet_ehash_insert() in
reqsk_timer_handler(), we jump to the no_ownership: label
and free the new reqsk immediately with __reqsk_free().

Thus, we must stop the new reqsk's timer before jumping to the
label, but the timer might be missed since the cited commit,
resulting in UAF.

As we are in the original reqsk's timer context, we can safely
call timer_delete_sync() for the new reqsk.

Let's pass false to __inet_csk_reqsk_queue_drop() to stop
the new reqsk's timer.

Fixes: 83fccfc3940c ("inet: fix potential deadlock in reqsk_queue_unlink()")
Reported-by: Damiano Melotti <melotti@google.com>
Signed-off-by: Kuniyuki Iwashima <kuniyu@google.com>
Link: https://patch.msgid.link/20260506035954.1563147-2-kuniyu@google.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/ipv4/inet_connection_sock.c