]> git.ipfire.org Git - thirdparty/postgresql.git/commit
Suppress -Warray-bounds warning in 9.2's xlog.c.
authorTom Lane <tgl@sss.pgh.pa.us>
Mon, 13 Dec 2021 16:57:11 +0000 (11:57 -0500)
committerTom Lane <tgl@sss.pgh.pa.us>
Mon, 13 Dec 2021 16:57:11 +0000 (11:57 -0500)
commit985c8de212faa5a4c983005d4192fb7e543cf5ab
tree7417d1e9dc6e8dd53548639dc8c7b2dfa0095377
parent3f9700acb238fced605ff3ef155e179290fd4f02
Suppress -Warray-bounds warning in 9.2's xlog.c.

Late-model gcc delivers a confusing warning "'memcpy' offset [0, 63]
is out of the bounds [0, 0]" here, which turns out to be because it
thinks the "record" pointer might be NULL, which again is because
it doesn't know ereport(PANIC) won't return.  The least invasive
way to fix that is to insert a couple of abort() calls.  It's
surprising/fortunate that we don't have this issue in more places
... but this is the last remaining build warning with gcc 11.2.1,
so I'll settle for a narrow fix.

Discussion: https://postgr.es/m/d0316012-ece7-7b7e-2d36-9c38cb77cb3b@enterprisedb.com
src/backend/access/transam/xlog.c