]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
arm64: ptrace: change fs when passing kernel pointer to regset code
authorWill Deacon <will.deacon@arm.com>
Mon, 2 Jun 2014 10:47:23 +0000 (11:47 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 1 Jul 2014 03:13:55 +0000 (20:13 -0700)
commit993e3e16565178b94d38c20fd1c81eb020b2fe8f
treee653c244a087eda302e4de316aa4659473cdd12e
parent3d672e43c3dc0549fee9af8b6b6142dfba425d62
arm64: ptrace: change fs when passing kernel pointer to regset code

commit c168870704bcde6bb63d05f7882b620dd3985a46 upstream.

Our compat PTRACE_POKEUSR implementation simply passes the user data to
regset_copy_from_user after some simple range checking. Unfortunately,
the data in question has already been copied to the kernel stack by this
point, so the subsequent access_ok check fails and the ptrace request
returns -EFAULT. This causes problems tracing fork() with older versions
of strace.

This patch briefly changes the fs to KERNEL_DS, so that the access_ok
check passes even with a kernel address.

Signed-off-by: Will Deacon <will.deacon@arm.com>
Signed-off-by: Catalin Marinas <catalin.marinas@arm.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
arch/arm64/kernel/ptrace.c