]> git.ipfire.org Git - thirdparty/linux.git/commit
thunderbolt: Initialize ->domain_released completion before it is being used
authorMika Westerberg <mika.westerberg@linux.intel.com>
Tue, 28 Jul 2026 06:15:39 +0000 (09:15 +0300)
committerMika Westerberg <mika.westerberg@linux.intel.com>
Thu, 30 Jul 2026 04:47:32 +0000 (06:47 +0200)
commit9cbc63400f7dc000adf898bbbc8208dfd93091d7
tree6f2b28ed12bbc03b84a5d820acb21513ec6e3669
parente48844ece5e3ed1d1eb865f6da2b16f62cd9f86d
thunderbolt: Initialize ->domain_released completion before it is being used

Both Woody and Marek reported following crash:

 BUG: unable to handle page fault for address: fffffffffffffff8
 Call Trace:
  <TASK>
  device_release+0x43/0x90
  kobject_cleanup+0x3c/0x180
  icm_probe+0x19c/0x550 [thunderbolt]
  nhi_probe+0x1a4/0x370 [thunderbolt]
  local_pci_probe+0x41/0x90
  pci_call_probe+0x5b/0x1a0
  ...

This only triggers on the error path when icm_probe() fails and the
domain structure is released, it tries to complete() uninitialized
completion.

Fix this by initializing the completion earlier.

Reported-by: Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
Closes: https://lore.kernel.org/linux-usb/amdezCBiW4fd_DuB@mail-itl/
Reported-by: Woody Suwalski <terraluna977@gmail.com>
Tested_by: Woody Suwalski <terraluna977@gmail.com>
Closes: https://lore.kernel.org/linux-usb/62caf7f8-b403-d0dd-15bc-b31b56f71c28@gmail.com/
Fixes: f5cc545f5969 ("thunderbolt: Wait for tb_domain_release() to complete when driver is removed")
Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
drivers/thunderbolt/nhi.c