]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
ntfs: Use return instead of goto in ntfs_mapping_pairs_decompress()
authorNathan Chancellor <nathan@kernel.org>
Tue, 28 Apr 2026 19:21:38 +0000 (15:21 -0400)
committerNamjae Jeon <linkinjeon@kernel.org>
Wed, 29 Apr 2026 22:05:48 +0000 (07:05 +0900)
commit9e9354075d5a15cfc0aba965f3d0d77b7d4303e9
tree78908e713f19cea613189a90c37a85c6bd6a423c
parent4ebcf3f94924d54706de0d2492c80944d85410fd
ntfs: Use return instead of goto in ntfs_mapping_pairs_decompress()

Clang warns (or errors with CONFIG_WERROR=y / W=e):

  fs/ntfs/runlist.c:755:6: error: variable 'rl' is used uninitialized whenever 'if' condition is true [-Werror,-Wsometimes-uninitialized]
    755 |         if (overflows_type(lowest_vcn, vcn)) {
        |             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  ...
  fs/ntfs/runlist.c:971:9: note: uninitialized use occurs here
    971 |         kvfree(rl);
        |                ^~
  ...

rl has not been allocated at this point so the 'goto err_out' should
really just be a return of the error pointer -EIO.

Signed-off-by: Nathan Chancellor <nathan@kernel.org>
Reviewed-by: Hyunchul Lee <hyc.lee@gmail.com>
Signed-off-by: Namjae Jeon <linkinjeon@kernel.org>
fs/ntfs/runlist.c