]> git.ipfire.org Git - thirdparty/Python/cpython.git/commit
[3.12] gh-144833: Fix use-after-free in SSL module when SSL_new() fails (GH-144843...
authorMiss Islington (bot) <31488909+miss-islington@users.noreply.github.com>
Mon, 23 Feb 2026 14:50:38 +0000 (15:50 +0100)
committerGitHub <noreply@github.com>
Mon, 23 Feb 2026 14:50:38 +0000 (15:50 +0100)
commit9fc477cd1da0813709d021dc960be1aa3aa1e670
treeced1ad6c0d8f60450d0d8fc1995285f7862405df
parente417f05ad77a4c30ddc07f99e90fc0cef43e831a
[3.12] gh-144833: Fix use-after-free in SSL module when SSL_new() fails (GH-144843) (#144860)

gh-144833: Fix use-after-free in SSL module when SSL_new() fails (GH-144843)

In newPySSLSocket(), when SSL_new() returns NULL, Py_DECREF(self)
was called before _setSSLError(get_state_ctx(self), ...), causing
a use-after-free. Additionally, get_state_ctx() was called with
self (PySSLSocket*) instead of sslctx (PySSLContext*), which is
a type confusion bug.

Fix by calling _setSSLError() before Py_DECREF() and using
sslctx instead of self for get_state_ctx().
(cherry picked from commit c91638ca0671b8038831f963ed44e66cdda006a2)

Co-authored-by: Ramin Farajpour Cami <ramin.blackhat@gmail.com>
Misc/NEWS.d/next/Library/2026-02-15-00-00-00.gh-issue-144833.TUelo1.rst [new file with mode: 0644]
Modules/_ssl.c