]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
ipmi: fix refcount leak in i_ipmi_request()
authorWentao Liang <vulab@iscas.ac.cn>
Wed, 3 Jun 2026 12:06:34 +0000 (12:06 +0000)
committerCorey Minyard <corey@minyard.net>
Wed, 3 Jun 2026 12:20:31 +0000 (07:20 -0500)
commita3f3859cecacb64f18fd446271ece9a3b3f2d4de
tree01f931a7786bf98dee9c52cfea5d50e8ad9175a2
parent1aec36f2f362e4e6d25413113fc363c2c57a9aa0
ipmi: fix refcount leak in i_ipmi_request()

When a caller provides a `supplied_recv` message to i_ipmi_request(),
the function increments the user's `nr_msgs` reference count. If an
error occurs later, the out_err cleanup path only frees the recv_msg
if the function allocated it itself (i.e., !supplied_recv). In the
supplied_recv case the cleanup is skipped, leaving the reference count
elevated. The caller ipmi_request_supply_msgs() does not release the
supplied_recv on error, so the reference is permanently leaked.

Fix this by explicitly reverting the reference count operations when a
supplied recv_msg with a valid user pointer is present in the error
path: decrement nr_msgs and drop the user's kref.

Cc: stable@vger.kernel.org
Fixes: b52da4054ee0 ("ipmi: Rework user message limit handling")
Signed-off-by: Wentao Liang <vulab@iscas.ac.cn>
Message-ID: <20260603120634.3758747-1-vulab@iscas.ac.cn>
Signed-off-by: Corey Minyard <corey@minyard.net>
drivers/char/ipmi/ipmi_msghandler.c