]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
drm/bridge: waveshare-dsi: Fix signedness bug
authorEthan Tidmore <ethantidmore06@gmail.com>
Sat, 7 Mar 2026 03:32:45 +0000 (21:32 -0600)
committerLuca Ceresoli <luca.ceresoli@bootlin.com>
Tue, 17 Mar 2026 17:04:08 +0000 (18:04 +0100)
commita469749640fbcd2f49ab05fb83cca3da07f35ee3
treef932c0b9221eacdd180baa9c6e62fea0b575259a
parent27a39e135f5c1ceaf73e64648eccdb42b751d5c7
drm/bridge: waveshare-dsi: Fix signedness bug

The function drm_of_get_data_lanes_count_ep() returns negative error
codes and dsi->lanes is an unsigned integer, so the check (dsi->lanes <
0) is always impossible.

Make the return value of drm_of_get_data_lanes_count_ep() be assigned to
ret, check for error, and then assign dsi->lanes to ret.

Detected by Smatch:
drivers/gpu/drm/bridge/waveshare-dsi.c:70 ws_bridge_attach_dsi() warn:
unsigned 'dsi->lanes' is never less than zero.

Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202603060341.hNj0pl9L-lkp@intel.com/
Fixes: fca11428425e9 ("drm/bridge: waveshare-dsi: Add support for 1..4 DSI data lanes")
Signed-off-by: Ethan Tidmore <ethantidmore06@gmail.com>
Reviewed-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
Reviewed-by: Marek Vasut <marek.vasut+renesas@mailbox.org>
Link: https://patch.msgid.link/20260307033245.71666-1-ethantidmore06@gmail.com
Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
drivers/gpu/drm/bridge/waveshare-dsi.c