]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
drm/amd/display: Refactor and fix link_dpms I2C
authorDominik Kaszewski <dominik.kaszewski@amd.com>
Thu, 29 Jan 2026 10:26:13 +0000 (11:26 +0100)
committerAlex Deucher <alexander.deucher@amd.com>
Mon, 23 Feb 2026 19:16:29 +0000 (14:16 -0500)
commita4f01bf729b2e0042bc725bb6254a8abea17f1a7
treeac3f4fff958c8d03324f9d2809457191118d534c
parent49bf43ac9838553b63bcd32b84e87f834a7e2234
drm/amd/display: Refactor and fix link_dpms I2C

[Why]
link_dpms.c issues I2C writes during HDMI link enablement. Current
implementation contains a lot of duplicated code with copy-paste
errors.

[How]
* Refactor common logic into helper functions.
* Invert logic with early returns to decrease indentation.
* Sequence writes by looping over data arrays.
* Fix write_i2c_retimer_setting is_over_340mhz checking reg_settings
instead of reg_settings_6g in the i2c_reg_index <= 0x20 check.

Reviewed-by: Wenjing Liu <wenjing.liu@amd.com>
Signed-off-by: Dominik Kaszewski <dominik.kaszewski@amd.com>
Signed-off-by: Ray Wu <ray.wu@amd.com>
Tested-by: Daniel Wheeler <daniel.wheeler@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/display/dc/link/link_dpms.c