]> git.ipfire.org Git - thirdparty/squid.git/commit
Bugzilla #1457
authorwessels <>
Tue, 6 Dec 2005 07:01:23 +0000 (07:01 +0000)
committerwessels <>
Tue, 6 Dec 2005 07:01:23 +0000 (07:01 +0000)
commita546b04bd9c6770fc35bafaa8709335664caef2c
tree097c9b74ee6e932817e996c010fc297a7d27f850
parentab7ac359cc18e0fa69c9fe0af937701ec44aa8c8
Bugzilla #1457

My changes to the way that the client-side performed http_access,
redirector, and no_cache checks introduced a serious bug.  Using
any proxy authentication would crash Squid.

One problem was that clientAccessCheckDone() should have returned
after generating the error page.  Instead it tried to keep going,
as though access were allowed.

The other problem was due to a recently added assertion, which was
incorrect.  Instead of asserting, the ClientRequestContext destructor
now releases its lock on the parent ClientHttpRequest if necessary.
src/client_side_request.cc