]> git.ipfire.org Git - thirdparty/linux.git/commit
smb: client: scope end_of_dacl to CIFS_DEBUG2 use in parse_dacl
authorMichael Bommarito <michael.bommarito@gmail.com>
Tue, 21 Apr 2026 23:40:22 +0000 (19:40 -0400)
committerSteve French <stfrench@microsoft.com>
Wed, 22 Apr 2026 14:54:26 +0000 (09:54 -0500)
commita55a60886e612bedb0e9a402ba0dca544c4c6a51
tree5da7139e6af12aa27c4ab15d729942b13cf904e2
parent17d912d54f23058b0d21ccf85e785b9601dc6959
smb: client: scope end_of_dacl to CIFS_DEBUG2 use in parse_dacl

After validate_dacl() was factored out in commit 149822e5541c, the
local end_of_dacl in parse_dacl() is only read by the dump_ace()
call under #ifdef CONFIG_CIFS_DEBUG2.  With CIFS_DEBUG2 off the
variable is assigned but never used, which gcc -W=1 flags as
-Wunused-but-set-variable.

Remove the local and compute the end-of-dacl pointer inline at the
single call site inside the existing CIFS_DEBUG2 guard.  No
functional change: when CIFS_DEBUG2 is enabled the argument value
is identical to what the removed local carried; when CIFS_DEBUG2
is disabled the code was already dead.

Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202604220046.tGkRxVtS-lkp@intel.com/
Fixes: 149822e5541c ("smb: client: validate the whole DACL before rewriting it in cifsacl")
Signed-off-by: Michael Bommarito <michael.bommarito@gmail.com>
Assisted-by: Claude:claude-opus-4-7
Signed-off-by: Steve French <stfrench@microsoft.com>
fs/smb/client/cifsacl.c