]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
fwctl: Fix class init ordering to avoid NULL pointer dereference on device removal
authorRichard Cheng <icheng@nvidia.com>
Thu, 9 Apr 2026 05:19:02 +0000 (13:19 +0800)
committerJason Gunthorpe <jgg@nvidia.com>
Fri, 10 Apr 2026 14:21:06 +0000 (11:21 -0300)
commita55f80233f384dc89ef3425b2e1dd0e6d44bcf29
tree600e5b8cf27ffe0d61b9bce8dffe023e5c178192
parent44230bb342ffba040d56b0dc24c478797aad9b38
fwctl: Fix class init ordering to avoid NULL pointer dereference on device removal

CXL is linked before fwctl in drivers/Makefile. Both use `module_init, so
`cxl_pci_driver_init()` runs first. When `cxl_pci_probe()` calls
`fwctl_register()` and then `device_add()`, fwctl_class is not yet
registered because fwctl_init() hasn't run, causing `class_to_subsys()` to
return NULL and skip knode_class initialization.

On device removal, `class_to_subsys()` returns non-NULL, and
`device_del()` calls `klist_del()` on the uninitialized knode, triggering
a NULL pointer dereference.

Fixes: 858ce2f56b52 ("cxl: Add FWCTL support to CXL")
Link: https://patch.msgid.link/r/20260409051902.40218-1-icheng@nvidia.com
Signed-off-by: Richard Cheng <icheng@nvidia.com>
Reviewed-by: Kai-Heng Feng <kaihengf@nvidia.com>
Reviewed-by: Dave Jiang <dave.jiang@intel.com>
Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
drivers/fwctl/main.c