]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
ppp: simplify input error handling
authorQingfang Deng <dqfext@gmail.com>
Fri, 6 Mar 2026 09:36:49 +0000 (17:36 +0800)
committerJakub Kicinski <kuba@kernel.org>
Tue, 10 Mar 2026 02:07:38 +0000 (19:07 -0700)
commitabb0eb0b033a0a8980eb9215e02626e4801ead3f
tree61202f608353a206112e6fa8acfcd32a6c58deeb
parent58e4d35ae7b9325ab622bbcc34312b17af425c8f
ppp: simplify input error handling

Currently, ppp_input_error() indicates an error by allocating a 0-length
skb and calling ppp_do_recv(). It takes an error code argument, which is
stored in skb->cb, but not used by ppp_receive_frame().

Simplify the error handling by removing the unused parameter and the
unnecessary skb allocation. Instead, call ppp_receive_error() directly
from ppp_input_error() under the recv lock, and the length check in
ppp_receive_frame() can be removed.

Signed-off-by: Qingfang Deng <dqfext@gmail.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ppp/ppp_async.c
drivers/net/ppp/ppp_generic.c
drivers/net/ppp/ppp_synctty.c
include/linux/ppp_channel.h
net/atm/pppoatm.c