]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
net: macb: use ethtool_sprintf to fill ethtool stats strings
authorSean Chang <seanwascoding@gmail.com>
Mon, 2 Mar 2026 14:29:31 +0000 (22:29 +0800)
committerJakub Kicinski <kuba@kernel.org>
Wed, 4 Mar 2026 01:18:00 +0000 (17:18 -0800)
commitacd338ba2f3a33d68aa05f406407fbdf6adccfee
treebc9ebe6897b9dc2f3a31c73f251de3615a8fa46b
parent39feb171f361f887dad8504dc5822b852871ac21
net: macb: use ethtool_sprintf to fill ethtool stats strings

The RISC-V toolchain triggers a stringop-truncation warning when using
snprintf() with a fixed ETH_GSTRING_LEN (32 bytes) buffer.

Convert the driver to use the modern ethtool_sprintf() API from
linux/ethtool.h. This removes the need for manual snprintf() and
memcpy() calls, handles the 32-byte padding automatically, and
simplifies the logic by removing manual pointer arithmetic.

Suggested-by: Andrew Lunn <andrew@lunn.ch>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
Signed-off-by: Sean Chang <seanwascoding@gmail.com>
Link: https://patch.msgid.link/20260302142931.49108-1-seanwascoding@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/cadence/macb_main.c