]> git.ipfire.org Git - thirdparty/postgresql.git/commit
Fix bogus use of "long" in AllocSetCheck()
authorDavid Rowley <drowley@postgresql.org>
Thu, 30 Oct 2025 01:49:07 +0000 (14:49 +1300)
committerDavid Rowley <drowley@postgresql.org>
Thu, 30 Oct 2025 01:49:07 +0000 (14:49 +1300)
commitaf3a79e0837d23fa536f859fc927b1379855ae24
tree46c998f1a796f19bf7b86195b43c31e6b05c8b4f
parentb1635c166698a2b70aa3f397d0f7ca6844872dce
Fix bogus use of "long" in AllocSetCheck()

Because long is 32-bit on 64-bit Windows, it isn't a good datatype to
store the difference between 2 pointers.  The under-sized type could
overflow and lead to scary warnings in MEMORY_CONTEXT_CHECKING builds,
such as:

WARNING:  problem in alloc set ExecutorState: bad single-chunk %p in block %p

However, the problem lies only in the code running the check, not from
an actual memory accounting bug.

Fix by using "Size" instead of "long".  This means using an unsigned
type rather than the previous signed type.  If the block's freeptr was
corrupted, we'd still catch that if the unsigned type wrapped.  Unsigned
allows us to avoid further needless complexities around comparing signed
and unsigned types.

Author: David Rowley <dgrowleyml@gmail.com>
Reviewed-by: Michael Paquier <michael@paquier.xyz>
Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>
Backpatch-through: 13
Discussion: https://postgr.es/m/CAApHDvo-RmiT4s33J=aC9C_-wPZjOXQ232V-EZFgKftSsNRi4w@mail.gmail.com
src/backend/utils/mmgr/aset.c