]> git.ipfire.org Git - thirdparty/asterisk.git/commit
app_dial.c: Moved channel lock to prevent deadlock
authorAlexey Khabulyak <khabalex@gmail.com>
Mon, 4 Aug 2025 14:48:57 +0000 (17:48 +0300)
committergithub-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Mon, 11 Aug 2025 14:37:22 +0000 (14:37 +0000)
commitb0421fc87c6f9c900635c701036e607d6402857d
tree63575f58edc9fa6dafc5b9d830538878f4f73fcf
parentdce107234aef50f3fa0a01fbbb6f11fc3ece86cc
app_dial.c: Moved channel lock to prevent deadlock

It's reproducible with pbx_lua, not regular dialplan.

deadlock description:
1. asterisk locks a channel
2. calls function onedigit_goto
3. calls ast_goto_if_exists funciton
4. checks ast_exists_extension -> pbx_extension_helper
5. pbx_extension_helper calls pbx_find_extension
6. Then asterisk starts autoservice in a new thread
7. autoservice run tries to lock the channel again

Because our channel is locked already, autoservice can't lock.
Autoservice can't lock -> autoservice stop is waiting forever.
onedigit_goto waits for autoservice stop.

Resolves: https://github.com/asterisk/asterisk/issues/1335
apps/app_dial.c