]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
HID: google: hammer: stop hardware on devres action failure
authorMyeonghun Pak <mhun512@gmail.com>
Fri, 24 Apr 2026 12:50:41 +0000 (21:50 +0900)
committerJiri Kosina <jkosina@suse.com>
Tue, 12 May 2026 16:01:05 +0000 (18:01 +0200)
commitb08665fe80fab0956e64741c07d9bbcec635c34d
tree5c8efc09d9e3f6cbe1d477b75a4eb4474e973d59
parent1654e53349d4e657b331de354313461f401f5063
HID: google: hammer: stop hardware on devres action failure

hammer_probe() starts the HID hardware before registering the devres
action that stops it. If devm_add_action() fails, probe returns an
error with the hardware still started because the cleanup action was
never registered and the driver's remove callback is not called after a
failed probe.

Use devm_add_action_or_reset() so the stop action runs immediately on
registration failure while preserving the existing devres-managed cleanup
path for later probe failures and remove.

Signed-off-by: Myeonghun Pak <mhun512@gmail.com>
Signed-off-by: Jiri Kosina <jkosina@suse.com>
drivers/hid/hid-google-hammer.c