]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
sched/mmcid: Prevent CID stalls due to concurrent forks
authorThomas Gleixner <tglx@kernel.org>
Tue, 10 Mar 2026 20:28:53 +0000 (21:28 +0100)
committerPeter Zijlstra <peterz@infradead.org>
Wed, 11 Mar 2026 11:01:06 +0000 (12:01 +0100)
commitb2e48c429ec54715d16fefa719dd2fbded2e65be
tree65702f5961c3893bb9d64547e6bb2bc360a4f8d2
parent1f318b96cc84d7c2ab792fcc0bfd42a7ca890681
sched/mmcid: Prevent CID stalls due to concurrent forks

A newly forked task is accounted as MMCID user before the task is visible
in the process' thread list and the global task list. This creates the
following problem:

 CPU1 CPU2
 fork()
   sched_mm_cid_fork(tnew1)
     tnew1->mm.mm_cid_users++;
     tnew1->mm_cid.cid = getcid()
-> preemption
fork()
  sched_mm_cid_fork(tnew2)
    tnew2->mm.mm_cid_users++;
                            // Reaches the per CPU threshold
    mm_cid_fixup_tasks_to_cpus()
    for_each_other(current, p)
         ....

As tnew1 is not visible yet, this fails to fix up the already allocated CID
of tnew1. As a consequence a subsequent schedule in might fail to acquire a
(transitional) CID and the machine stalls.

Move the invocation of sched_mm_cid_fork() after the new task becomes
visible in the thread and the task list to prevent this.

This also makes it symmetrical vs. exit() where the task is removed as CID
user before the task is removed from the thread and task lists.

Fixes: fbd0e71dc370 ("sched/mmcid: Provide CID ownership mode fixup functions")
Signed-off-by: Thomas Gleixner <tglx@kernel.org>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Tested-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
Link: https://patch.msgid.link/20260310202525.969061974@kernel.org
include/linux/sched.h
kernel/fork.c
kernel/sched/core.c