]> git.ipfire.org Git - thirdparty/postgresql.git/commit
Fix GUC check_hook validation for synchronized_standby_slots.
authorAmit Kapila <akapila@postgresql.org>
Mon, 27 Oct 2025 06:37:35 +0000 (06:37 +0000)
committerAmit Kapila <akapila@postgresql.org>
Mon, 27 Oct 2025 06:37:35 +0000 (06:37 +0000)
commitb45a8d7d8b306b43f31a002f1b3f1dddc8defeaf
tree15592d436f167563b2ef944707ed3986351583c2
parenta2387c32f2f8a1643c7d71b951587e6bcb2d4744
Fix GUC check_hook validation for synchronized_standby_slots.

Previously, the check_hook for synchronized_standby_slots attempted to
validate that each specified slot existed and was physical. However, these
checks were not performed during server startup. As a result, if users
configured non-existent slots before startup, the misconfiguration would
go undetected initially. This could later cause parallel query failures,
as newly launched workers would detect the issue and raise an ERROR.

This patch improves the check_hook by validating the syntax and format of
slot names. Validation of slot existence and type is deferred to the WAL
sender process, aligning with the behavior of the check_hook for
primary_slot_name.

Reported-by: Fabrice Chapuis <fabrice636861@gmail.com>
Author: Shlok Kyal <shlok.kyal.oss@gmail.com>
Reviewed-by: Hayato Kuroda <kuroda.hayato@fujitsu.com>
Reviewed-by: Amit Kapila <amit.kapila16@gmail.com>
Reviewed-by: Ashutosh Sharma <ashu.coek88@gmail.com>
Reviewed-by: Rahila Syed <rahilasyed90@gmail.com>
Backpatch-through: 17, where it was introduced
Discussion: https://postgr.es/m/CAA5-nLCeO4MQzWipCXH58qf0arruiw0OeUc1+Q=Z=4GM+=v1NQ@mail.gmail.com
src/backend/replication/slot.c
src/test/modules/unsafe_tests/expected/guc_privs.out
src/test/modules/unsafe_tests/sql/guc_privs.sql