]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
lib/bootconfig: check xbc_init_node() return in override path
authorJosh Law <objecting@objecting.org>
Wed, 18 Mar 2026 23:43:05 +0000 (08:43 +0900)
committerMasami Hiramatsu (Google) <mhiramat@kernel.org>
Wed, 18 Mar 2026 23:43:05 +0000 (08:43 +0900)
commitbb288d7d869e86d382f35a0e26242c5ccb05ca82
treeec61a86fb42565aeca7f2e3aab734b2ad3544456
parentf338e77383789c0cae23ca3d48adcc5e9e137e3c
lib/bootconfig: check xbc_init_node() return in override path

The ':=' override path in xbc_parse_kv() calls xbc_init_node() to
re-initialize an existing value node but does not check the return
value. If xbc_init_node() fails (data offset out of range), parsing
silently continues with stale node data.

Add the missing error check to match the xbc_add_node() call path
which already checks for failure.

In practice, a bootconfig using ':=' to override a value near the
32KB data limit could silently retain the old value, meaning a
security-relevant boot parameter override (e.g., a trace filter or
debug setting) would not take effect as intended.

Link: https://lore.kernel.org/all/20260318155847.78065-2-objecting@objecting.org/
Fixes: e5efaeb8a8f5 ("bootconfig: Support mixing a value and subkeys under a key")
Signed-off-by: Josh Law <objecting@objecting.org>
Signed-off-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>
lib/bootconfig.c