]> git.ipfire.org Git - thirdparty/linux.git/commit
ppp: require callers of ppp_dev_name() to hold RCU
authorQingfang Deng <dqfext@gmail.com>
Mon, 16 Mar 2026 09:28:23 +0000 (17:28 +0800)
committerJakub Kicinski <kuba@kernel.org>
Tue, 17 Mar 2026 23:18:48 +0000 (16:18 -0700)
commitbb8539e0e60916ef3ed4a92eb2f3cfd8e34061ef
tree69c7271bc3fcb8d7991d241a99a0aee4cd156996
parente3f741f587a9826a82304bb5da021e0fe783795d
ppp: require callers of ppp_dev_name() to hold RCU

ppp_dev_name() holds the RCU read lock internally to protect pch->ppp.
However, as it returns netdev->name to the caller, the caller should
also hold either RCU or RTNL lock to prevent the netdev from being
freed.

The only two references of the function is in the L2TP driver, both of
which already hold RCU. So remove the internal RCU lock and document
that callers must hold RCU.

Signed-off-by: Qingfang Deng <dqfext@gmail.com>
Reviewed-by: Breno Leitao <leitao@debian.org>
Link: https://patch.msgid.link/20260316092824.479149-1-dqfext@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ppp/ppp_generic.c
include/linux/ppp_channel.h