]> git.ipfire.org Git - thirdparty/libvirt.git/commit
qemu: rdp: Fix 'qemuRdpAvailable()'
authorPeter Krempa <pkrempa@redhat.com>
Mon, 7 Apr 2025 16:16:15 +0000 (18:16 +0200)
committerPeter Krempa <pkrempa@redhat.com>
Wed, 9 Apr 2025 16:05:26 +0000 (18:05 +0200)
commitbd473480b443aa2561236dfd903535aa778d99a8
tree929bed626c4a735e21d931bf1ce0fcb58111e9fd
parent59f40ba67cc7d0a3f8eeb601c2f3c84def24a361
qemu: rdp: Fix 'qemuRdpAvailable()'

qemuRdpAvailable() is called from the capability filing code, thus:
- it must not report spurious errors
- it should not call any extra processes

We can solve the above by just checking existance of 'qemu-rdp' in the
path as:
- at the time of adding of qemuRdpAvailable() there was only one 'qemu-rdp' release
- it supported all the features
- the check can't change as we'd drop the capability

Add comments and gut the check to only check existance of the file.

Fixes: f5e5a9bec9ec3e6c762f5000e3b8a0ba6a3a8c8d
Closes: https://gitlab.com/libvirt/libvirt/-/issues/763
Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Boris Fiuczynski <fiuczy@linux.ibm.com>
src/qemu/qemu_rdp.c