]> git.ipfire.org Git - thirdparty/postgresql.git/commit
Don't cast off_t to 32-bit type for output, bug fix
authorPeter Eisentraut <peter@eisentraut.org>
Wed, 1 Jul 2026 07:40:36 +0000 (09:40 +0200)
committerPeter Eisentraut <peter@eisentraut.org>
Wed, 1 Jul 2026 07:49:39 +0000 (09:49 +0200)
commitc754d9311509e3d3d2f22d264151e040e7a2d832
tree3e9af3963e03e9ffe4baaac53e2923a270764b1b
parent225dd7ab4e6a48b1172bea26826a062f9d44f9cc
Don't cast off_t to 32-bit type for output, bug fix

off_t is most likely a 64-bit integer, so casting it to a 32-bit type
for output could lose data.  There are more issues like this in the
tree, but this is an instance where this could actually happen in
practice, since base backups are routinely larger than 4 GB.  So this
is separated out as a bug fix.

Reviewed-by: Heikki Linnakangas <hlinnaka@iki.fi>
Discussion: https://www.postgresql.org/message-id/flat/20ce62fa-47fc-457b-b504-12f3c1651726%40eisentraut.org
src/backend/backup/basebackup_server.c