]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
mtd: docg3: fix use-after-free in docg3_release()
authorJames Kim <james010kim@gmail.com>
Mon, 9 Mar 2026 06:05:12 +0000 (15:05 +0900)
committerMiquel Raynal <miquel.raynal@bootlin.com>
Wed, 11 Mar 2026 15:24:10 +0000 (16:24 +0100)
commitca19808bc6fac7e29420d8508df569b346b3e339
tree7f0a2baafc685fecf22848fbffcc65034d5a6172
parente19eaffc5213fdd6179e849d3032929fae0d8c2c
mtd: docg3: fix use-after-free in docg3_release()

In docg3_release(), the docg3 pointer is obtained from
cascade->floors[0]->priv before the loop that calls
doc_release_device() on each floor. doc_release_device() frees the
docg3 struct via kfree(docg3) at line 1881. After the loop,
docg3->cascade->bch dereferences the already-freed pointer.

Fix this by accessing cascade->bch directly, which is equivalent
since docg3->cascade points back to the same cascade struct, and
is already available as a local variable. This also removes the
now-unused docg3 local variable.

Fixes: c8ae3f744ddc ("lib/bch: Rework a little bit the exported function names")
Cc: stable@vger.kernel.org
Signed-off-by: James Kim <james010kim@gmail.com>
Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
drivers/mtd/devices/docg3.c