]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
xfs: Fix error pointer dereference
authorEthan Tidmore <ethantidmore06@gmail.com>
Fri, 20 Feb 2026 03:38:25 +0000 (21:38 -0600)
committerCarlos Maiolino <cem@kernel.org>
Wed, 25 Feb 2026 12:58:48 +0000 (13:58 +0100)
commitcddfa648f1ab99e30e91455be19cd5ade26338c2
tree6d145832dd9c2ba1f5a3b5e9d7770315894ea1de
parent47553dd60b1da88df2354f841a4f71dd4de6478a
xfs: Fix error pointer dereference

The function try_lookup_noperm() can return an error pointer and is not
checked for one.

Add checks for error pointer in xrep_adoption_check_dcache() and
xrep_adoption_zap_dcache().

Detected by Smatch:
fs/xfs/scrub/orphanage.c:449 xrep_adoption_check_dcache() error:
'd_child' dereferencing possible ERR_PTR()

fs/xfs/scrub/orphanage.c:485 xrep_adoption_zap_dcache() error:
'd_child' dereferencing possible ERR_PTR()

Fixes: 73597e3e42b4 ("xfs: ensure dentry consistency when the orphanage adopts a file")
Cc: stable@vger.kernel.org # v6.16
Signed-off-by: Ethan Tidmore <ethantidmore06@gmail.com>
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
Reviewed-by: Nirjhar Roy (IBM) <nirjhar.roy.lists@gmail.com>
Signed-off-by: Carlos Maiolino <cem@kernel.org>
fs/xfs/scrub/orphanage.c