]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
net: shaper: reject QUEUE scope handle with missing id
authorJakub Kicinski <kuba@kernel.org>
Sun, 10 May 2026 19:29:04 +0000 (12:29 -0700)
committerPaolo Abeni <pabeni@redhat.com>
Tue, 12 May 2026 14:15:00 +0000 (16:15 +0200)
commitce372e869f9f492f3d5aa9a0ae75ed52c61d2d6f
tree566478e30be01de48ad47efdc0adc6847ffa0a94
parentb62b29e6de6711f5918940aa6ff2bbab6d6af502
net: shaper: reject QUEUE scope handle with missing id

net_shaper_parse_handle() does not enforce that the user provides
the handle ID. For NODE the ID defaults to UNSPEC for all other
cases it defaults to 0.

For NETDEV 0 is the only option. For QUEUE defaulting to 0 makes
less intuitive sense. Specifically because the behavior should
(IMHO) be the same for all cases where there may be more than
one ID (QUEUE and NODE).

We should either document this as intentional or reject.
I picked the latter with no strong conviction.

Fixes: 4b623f9f0f59 ("net-shapers: implement NL get operation")
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Link: https://patch.msgid.link/20260510192904.3987113-11-kuba@kernel.org
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
net/shaper/shaper.c