]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
netfilter: nf_conntrack: use get_unaligned_be32() in tcp_sack()
authorRosen Penev <rosenp@gmail.com>
Mon, 25 May 2026 21:58:40 +0000 (14:58 -0700)
committerPablo Neira Ayuso <pablo@netfilter.org>
Sun, 7 Jun 2026 09:13:47 +0000 (11:13 +0200)
commitd3bf9eae486490832bd08fd62ab0ac601f346bd4
treec584dcc5c5e67994a85c1608c1934c23c6bed74a
parente052f920773b73be49eb4d8702a9f85de7464363
netfilter: nf_conntrack: use get_unaligned_be32() in tcp_sack()

The timestamp-only fast path dereferences the option stream as
*(__be32 *)ptr, which assumes 4-byte alignment that the TCP option
stream does not guarantee. Use get_unaligned_be32() instead, which
reads the value safely and already returns host byte order, so the
htonl() on the comparison constant can be dropped.

This matches the existing get_unaligned_be32() use later in the same
function.

Assisted-by: Claude:Opus-4.7
Signed-off-by: Rosen Penev <rosenp@gmail.com>
Reviewed-by: Fernando Fernandez Mancera <fmancera@suse.de>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
net/netfilter/nf_conntrack_proto_tcp.c