]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
ASoC: SOF: topology: fix memory leak in snd_sof_load_topology
authorZhao Dongdong <zhaodongdong@kylinos.cn>
Wed, 10 Jun 2026 07:20:43 +0000 (15:20 +0800)
committerMark Brown <broonie@kernel.org>
Thu, 11 Jun 2026 20:41:33 +0000 (21:41 +0100)
commitd46f9f23897261da53ffbeb89d48a13982ba7d28
tree2ce229a7bfa783067d79d7d24dab4733f55ba843
parentf07dde7074252653a17905b45bf92150029a47ae
ASoC: SOF: topology: fix memory leak in snd_sof_load_topology

When the topology filename contains "dummy" and tplg_cnt is 0, the
function returns -EINVAL directly without freeing the tplg_files
allocated by kcalloc() at line 2497. This leaks memory on every
such topology load attempt.

Fix this by setting ret = -EINVAL and jumping to the out: label,
which already handles the kfree(tplg_files) cleanup.

Fixes: 99c159279c6d ("ASoC: SOF: don't check the existence of dummy topology")
Cc: stable@vger.kernel.org
Signed-off-by: Zhao Dongdong <zhaodongdong@kylinos.cn>
Acked-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
Link: https://patch.msgid.link/tencent_3EED6D778DC52C3703A2D1EE8119372E8E08@qq.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/sof/topology.c