]> git.ipfire.org Git - thirdparty/libvirt.git/commit
domain_conf.c: skip checking ZPCI address is incomplete if not present v6.5.0-rc1
authorDaniel Henrique Barboza <danielhb413@gmail.com>
Fri, 26 Jun 2020 21:49:00 +0000 (18:49 -0300)
committerAndrea Bolognani <abologna@redhat.com>
Sat, 27 Jun 2020 13:24:58 +0000 (15:24 +0200)
commitd482cf6bef484e697f1dbb99f2504e7d67b149e7
treecb767fed11f3bc610dccf4cecbd9a53070b00818
parentf6f745297d884453ef4ed65643d267069f778517
domain_conf.c: skip checking ZPCI address is incomplete if not present

Commit 076591009ad1 ("conf: fix zPCI address auto-generation on
s390") is doing a check for virZPCIDeviceAddressIsIncomplete()
prior to checking if the device has a ZPCI address at all. This
results in errors like these when starting libvirt:

  error : virDomainDeviceInfoFormat:7527 : internal error:
  Missing uid or fid attribute of zPCI address

Fix it by moving virZPCIDeviceAddressIsIncomplete() after the
check done by virZPCIDeviceAddressIsPresent().

Fixes: 076591009ad11ec108521b52a4945d0f895fa160
Signed-off-by: Daniel Henrique Barboza <danielhb413@gmail.com>
Reviewed-by: Andrea Bolognani <abologna@redhat.com>
src/conf/domain_conf.c