]> git.ipfire.org Git - thirdparty/linux.git/commit
bpf: Add missing access_ok call to copy_user_syms
authorJiri Olsa <jolsa@kernel.org>
Tue, 16 Jun 2026 08:30:56 +0000 (10:30 +0200)
committerAlexei Starovoitov <ast@kernel.org>
Mon, 22 Jun 2026 01:01:33 +0000 (18:01 -0700)
commitd5dc200c3a3f217de072af269dd90adddf90e48d
tree5cd0ea9ffed6b09da1a220e1214438ebc5d46c35
parent39799c63578ec64488e14aced9ea07af6f958f35
bpf: Add missing access_ok call to copy_user_syms

As reported by sashiko we use __get_user without prior access_ok call on the
user space pointer. Adding the missing call for the whole pointer array.

Plus removing the err check in the error path, because it's not needed and
also we can return -ENOMEM directly from the first kvmalloc_array fail path.

Cc: stable@vger.kernel.org
[1] https://lore.kernel.org/bpf/20260611115503.AC16D1F00893@smtp.kernel.org/
Fixes: 0236fec57a15 ("bpf: Resolve symbols with ftrace_lookup_symbols for kprobe multi link")
Reported-by: Sashiko <sashiko-bot@kernel.org>
Closes: https://lore.kernel.org/bpf/20260611115503.AC16D1F00893@smtp.kernel.org/
Signed-off-by: Jiri Olsa <jolsa@kernel.org>
Reviewed-by: Emil Tsalapatis <emil@etsalapatis.com>
Link: https://lore.kernel.org/r/20260616083056.405652-1-jolsa@kernel.org
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
kernel/trace/bpf_trace.c