]> git.ipfire.org Git - thirdparty/postgresql.git/commit
Reverse-engineer some documentation for btree_gist's varlena modules.
authorTom Lane <tgl@sss.pgh.pa.us>
Fri, 3 Jul 2026 17:18:13 +0000 (13:18 -0400)
committerTom Lane <tgl@sss.pgh.pa.us>
Fri, 3 Jul 2026 17:18:13 +0000 (13:18 -0400)
commitd6284bbd152c1ea9e73bc77d6cb26bbf636d569b
tree54fb041b53f7b42e0b9965a20c3fc9ed63b89cbb
parenta9fa6c69e3f5405866a0ebed27597e80760abc77
Reverse-engineer some documentation for btree_gist's varlena modules.

There are a number of rather subtle points about the behavior of
this code, which its original authors did not deign to document.
Try to improve that.  In particular, explain how internal and leaf
keys can differ and what the restrictions are on that.

This work arose from trying to fix some bugs, and in the process
I believe I've identified some more, but this patch does not attempt
to fix anything, only document it.  I did make a few purely cosmetic
code changes, such as removing dead (and confusing!) initializations
of variables and choosing more appropriate types for some pointers.

Author: Tom Lane <tgl@sss.pgh.pa.us>
Reviewed-by: Ayush Tiwari <ayushtiwari.slg01@gmail.com>
Discussion: https://postgr.es/m/AH*AvQCYKhQGVvPWi1GiU4oY.8.1781609375063.Hmail.3020001251@tju.edu.cn
contrib/btree_gist/btree_bit.c
contrib/btree_gist/btree_bytea.c
contrib/btree_gist/btree_numeric.c
contrib/btree_gist/btree_text.c
contrib/btree_gist/btree_utils_var.c
contrib/btree_gist/btree_utils_var.h