]> git.ipfire.org Git - thirdparty/linux.git/commit
thunderbolt: Bound the DROM dual link port number before indexing sw->ports
authorBryam Vargas <hexlabsecurity@proton.me>
Thu, 25 Jun 2026 11:54:09 +0000 (06:54 -0500)
committerMika Westerberg <mika.westerberg@linux.intel.com>
Mon, 27 Jul 2026 09:58:54 +0000 (11:58 +0200)
commitd6764992f17b23d91ff93ce905ab53c2aa7191f0
tree5c116f9ab1b2df38c059477b6a073229735962cf
parentd2ee4d47aacbd2ba456092eeec670dba35fde291
thunderbolt: Bound the DROM dual link port number before indexing sw->ports

tb_drom_parse_entry_port() validates the device-supplied header->index
against sw->config.max_port_number before indexing sw->ports[], but the
sibling field entry->dual_link_port_nr -- a 6-bit value also read from
the DROM -- indexes the same array with no such check. A malicious or
malformed Thunderbolt device can set dual_link_port_nr beyond the
allocated sw->ports[] (max_port_number + 1 entries), producing an
out-of-bounds tb_port pointer that is stored and later dereferenced.

Reject a port entry whose dual_link_port_nr exceeds max_port_number,
the same bound already applied to header->index.

Fixes: cd22e73bdf5e ("thunderbolt: Read port configuration from eeprom.")
Cc: stable@vger.kernel.org
Signed-off-by: Bryam Vargas <hexlabsecurity@proton.me>
Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
drivers/thunderbolt/eeprom.c