]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
packet: fix heap info leak in PACKET_DIAG_MCLIST sock_diag interface
authorMathias Krause <minipli@googlemail.com>
Sun, 10 Apr 2016 10:52:28 +0000 (12:52 +0200)
committerBen Hutchings <ben@decadent.org.uk>
Wed, 15 Jun 2016 20:29:23 +0000 (21:29 +0100)
commitd6db3a73d106fdb0eacdecec6be98cb15f1e07bc
tree0c8adb19fbbeaa5838439c11fe36535de94bcf78
parent85411d5615fcef2eaf230ec66c541e217428756f
packet: fix heap info leak in PACKET_DIAG_MCLIST sock_diag interface

commit 309cf37fe2a781279b7675d4bb7173198e532867 upstream.

Because we miss to wipe the remainder of i->addr[] in packet_mc_add(),
pdiag_put_mclist() leaks uninitialized heap bytes via the
PACKET_DIAG_MCLIST netlink attribute.

Fix this by explicitly memset(0)ing the remaining bytes in i->addr[].

Fixes: eea68e2f1a00 ("packet: Report socket mclist info via diag module")
Signed-off-by: Mathias Krause <minipli@googlemail.com>
Cc: Eric W. Biederman <ebiederm@xmission.com>
Cc: Pavel Emelyanov <xemul@parallels.com>
Acked-by: Pavel Emelyanov <xemul@virtuozzo.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
net/packet/af_packet.c