]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
bpf: Fix linked reg delta tracking when src_reg == dst_reg
authorDaniel Borkmann <daniel@iogearbox.net>
Tue, 7 Apr 2026 19:24:18 +0000 (21:24 +0200)
committerAlexei Starovoitov <ast@kernel.org>
Wed, 8 Apr 2026 01:15:42 +0000 (18:15 -0700)
commitd7f14173c0d5866c3cae759dee560ad1bed10d2e
treea54d03622c18a251e3459a71b1331d1153b2efdf
parent656e835bb0f850bdb7a42bfb64a2495f4f4d2064
bpf: Fix linked reg delta tracking when src_reg == dst_reg

Consider the case of rX += rX where src_reg and dst_reg are pointers to
the same bpf_reg_state in adjust_reg_min_max_vals(). The latter first
modifies the dst_reg in-place, and later in the delta tracking, the
subsequent is_reg_const(src_reg)/reg_const_value(src_reg) reads the
post-{add,sub} value instead of the original source.

This is problematic since it sets an incorrect delta, which sync_linked_regs()
then propagates to linked registers, thus creating a verifier-vs-runtime
mismatch. Fix it by just skipping this corner case.

Fixes: 98d7ca374ba4 ("bpf: Track delta between "linked" registers.")
Reported-by: STAR Labs SG <info@starlabs.sg>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Link: https://lore.kernel.org/r/20260407192421.508817-1-daniel@iogearbox.net
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
kernel/bpf/verifier.c