]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
ALSA: usb-audio: Update Babyface Pro control caches only after successful writes
authorCássio Gabriel <cassiogabrielcontato@gmail.com>
Wed, 29 Apr 2026 13:20:02 +0000 (10:20 -0300)
committerTakashi Iwai <tiwai@suse.de>
Wed, 29 Apr 2026 15:16:16 +0000 (17:16 +0200)
commitd8f802ccf1fdbeb89d62748d6a0d0fbd442c8127
tree6b911ac0dbd6f9fdd7ae749774b065f218bc2b75
parent6380957fa24251856a532e48a46a4dc3d1ae26b6
ALSA: usb-audio: Update Babyface Pro control caches only after successful writes

snd_bbfpro_ctl_put() and snd_bbfpro_vol_put()
cache the requested packed control state in
kcontrol->private_value before issuing the USB write.

Their get and resume paths use that cached value directly,
so a failed write can leave the driver reporting and later
replaying a setting the hardware never accepted.

Update the cached state only after a successful USB write.

Fixes: 3e8f3bd04716 ("ALSA: usb-audio: RME Babyface Pro mixer patch")
Cc: stable@vger.kernel.org
Signed-off-by: Cássio Gabriel <cassiogabrielcontato@gmail.com>
Link: https://patch.msgid.link/20260429-alsa-usb-quirks-cache-rollback-v1-2-01b35c688b80@gmail.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/usb/mixer_quirks.c