]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
pid_namespace: avoid optimization of accesses to ->child_reaper
authorPavel Tikhomirov <ptikhomirov@virtuozzo.com>
Wed, 18 Mar 2026 12:21:49 +0000 (13:21 +0100)
committerChristian Brauner <brauner@kernel.org>
Fri, 20 Mar 2026 13:44:25 +0000 (14:44 +0100)
commitd9c857aee2ebcdf5e9d81718b78b7966b8eee876
treef4003aa6169b05bf5907a37f208de86600490509
parent1f318b96cc84d7c2ab792fcc0bfd42a7ca890681
pid_namespace: avoid optimization of accesses to ->child_reaper

To avoid potential problems related to cpu/compiler optimizations around
->child_reaper, let's use WRITE_ONCE (additional to task_list lock)
everywhere we write it and use READ_ONCE where we read it without
explicit lock. Note: It also pairs with existing READ_ONCE with no lock
in nsfs_fh_to_dentry().

Also let's add ASSERT_EXCLUSIVE_WRITER before write to identify to KCSAN
that we don't expect any concurrent ->child_reaper modifications, and
those must be detected.

--

Suggested-by: Oleg Nesterov <oleg@redhat.com>
Acked-by: Oleg Nesterov <oleg@redhat.com>
Signed-off-by: Pavel Tikhomirov <ptikhomirov@virtuozzo.com>
Link: https://patch.msgid.link/20260318122157.280595-2-ptikhomirov@virtuozzo.com
v3: Split from main commit. Add ASSERT_EXCLUSIVE_WRITER.
v5: Add one more READ_ONCE for access without lock in free_pid().
Signed-off-by: Christian Brauner <brauner@kernel.org>
kernel/exit.c
kernel/fork.c
kernel/pid.c