]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
net: dpaa: fix mode setting
authorMichael Walle <mwalle@kernel.org>
Fri, 17 Jul 2026 13:20:29 +0000 (15:20 +0200)
committerJakub Kicinski <kuba@kernel.org>
Wed, 22 Jul 2026 19:45:40 +0000 (12:45 -0700)
commitda2c6bcc5e30b1496ac587785dcacf6e849eb6ef
treee6101508cb3e5e6c070c81673a1b2798a4ec206f
parentdcf15eaf5641812f1cfc5e96537380132a7da89d
net: dpaa: fix mode setting

Before converting to the phylink interface, the init function would have
set a non-reserved I/F mode in the maccfg2 register. After converting to
phylink, 0 is written as mode, which is a reserved value (although it's
the hardware default). Without a valid mode, a SGMII link is never
established between the MAC and the PHY and thus .link_up() is never
called which could set the correct mode according to the actual speed.

Fix it by setting the maximum speed of the phy_interface_t in use in
.mac_config() - just like the driver did before the phylink conversion.

Fixes: 5d93cfcf7360 ("net: dpaa: Convert to phylink")
Suggested-by: Sean Anderson <sean.anderson@linux.dev>
Signed-off-by: Michael Walle <mwalle@kernel.org>
Reviewed-by: Sean Anderson <sean.anderson@linux.dev>
Reviewed-by: Sean Anderson <sean.anderson@linux.dev>
Link: https://patch.msgid.link/20260717132401.2653252-1-mwalle@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/freescale/fman/fman_dtsec.c