]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
jfs: avoid -Wtautological-constant-out-of-range-compare warning again
authorArnd Bergmann <arnd@arndb.de>
Mon, 16 Mar 2026 14:42:51 +0000 (15:42 +0100)
committerDave Kleikamp <dave.kleikamp@oracle.com>
Mon, 16 Mar 2026 15:20:47 +0000 (10:20 -0500)
commitdad98c5b2a05ef744af4c884c97066a3c8cdad61
tree3186b0a53d950f6ce72ceca5fe8eec7dc732a7f0
parent679330e4a7af1d102d035b13b2b9d41bc1dfbbf7
jfs: avoid -Wtautological-constant-out-of-range-compare warning again

The comparison of an __s8 value against DTPAGEMAXSLOT is still trivially
true, causing a harmless (default disabled) warning with clang:

fs/jfs/jfs_dtree.c:4419:25: error: result of comparison of constant 128 with expression of type 's8' (aka 'signed char') is always false [-Werror,-Wtautological-constant-out-of-range-compare]
 4419 |                                         p->header.freelist >= DTPAGEMAXSLOT)) {
      |                                         ~~~~~~~~~~~~~~~~~~ ^  ~~~~~~~~~~~~~

I previously worked around two of these in commit 7833570dae83 ("jfs: avoid
-Wtautological-constant-out-of-range-compare warning"), but now a new one has
come up, so address the same way by dropping the redundant range check.

Fixes: 119e448bb50a ("jfs: add dtpage integrity check to prevent index/pointer overflows")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Dave Kleikamp <dave.kleikamp@oracle.com>
fs/jfs/jfs_dtree.c