]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
ovpn: fix use after free in unlock_ovpn()
authorMarco Baffo <marco@mandelbit.com>
Mon, 8 Jun 2026 14:04:46 +0000 (16:04 +0200)
committerAntonio Quartulli <antonio@openvpn.net>
Mon, 20 Jul 2026 13:49:55 +0000 (15:49 +0200)
commite1ad6fe5db719874efa45b2caf9934552e09fc43
tree14743d3560d9426422a0eea9978b8134b0b227d4
parent0bd9cfebc1c91e1066e56d6261b99691b9df6008
ovpn: fix use after free in unlock_ovpn()

unlock_ovpn() iterates over the release_list using llist_for_each_entry()
and drops the peer reference inside the loop body via ovpn_peer_put().

If this drops the last reference, the peer is eventually freed. However,
llist_for_each_entry() reads peer->release_entry.next in the loop advance
expression, which runs after the body. By that time the peer may have
already been freed, resulting in a use after free when advancing to the
next list entry.

Fix this by using llist_for_each_entry_safe(), which caches the next
pointer before executing the loop body.

Fixes: 80747caef33d ("ovpn: introduce the ovpn_peer object")
Signed-off-by: Marco Baffo <marco@mandelbit.com>
Signed-off-by: Antonio Quartulli <antonio@openvpn.net>
drivers/net/ovpn/peer.c