]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
perf/x86/intel/uncore: Fix iounmap() leak on global_init failure
authorZide Chen <zide.chen@intel.com>
Fri, 13 Mar 2026 17:40:47 +0000 (10:40 -0700)
committerPeter Zijlstra <peterz@infradead.org>
Tue, 7 Apr 2026 07:05:29 +0000 (09:05 +0200)
commite2a39d1a88f00ed83ebc7a19b7673d4ffd50b173
treecc2ad38265dbd4c946773d4c4439d3fee4f9fc6f
parent591cd656a1bf5ea94a222af5ef2ee76df029c1d2
perf/x86/intel/uncore: Fix iounmap() leak on global_init failure

Kernel test robot reported:

Unverified Error/Warning (likely false positive, kindly check if
interested):
    arch/x86/events/intel/uncore_discovery.c:293:2-8:
    ERROR: missing iounmap; ioremap on line 288 and execution via
    conditional on line 292

If domain->global_init() fails in __parse_discovery_table(), the
ioremap'ed MMIO region is not released before returning, resulting
in an MMIO mapping leak.

Fixes: b575fc0e3357 ("perf/x86/intel/uncore: Add domain global init callback")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Zide Chen <zide.chen@intel.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Reviewed-by: Dapeng Mi <dapeng1.mi@linux.intel.com>
Link: https://patch.msgid.link/20260313174050.171704-2-zide.chen@intel.com
arch/x86/events/intel/uncore_discovery.c