]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
selftests/cgroup: Fix cg_read_strcmp() empty string comparison
authorHongfu Li <lihongfu@kylinos.cn>
Sat, 9 May 2026 08:03:28 +0000 (16:03 +0800)
committerTejun Heo <tj@kernel.org>
Mon, 11 May 2026 01:53:44 +0000 (15:53 -1000)
commite32e6f02168f2ad7991eb5d160d312d2001520c8
treea515f206b16eed84f20d37273b1a86b33e819736
parent796ad622040f7f955ccc3973085e953415920496
selftests/cgroup: Fix cg_read_strcmp() empty string comparison

cg_read_strcmp() allocated a buffer sized to strlen(expected) + 1,
then passed it to read_text() which calls read(fd, buf, size-1).

When comparing against an empty string (""), strlen("") = 0 gives a
1-byte buffer, and read() is asked to read 0 bytes.  The file content
is never actually read, so strcmp("", buf) always returns 0 regardless
of the real content.  This caused cg_test_proc_killed() to always
report the cgroup as empty immediately, making OOM tests pass without
verifying that processes were killed.

Signed-off-by: Hongfu Li <lihongfu@kylinos.cn>
Signed-off-by: Tejun Heo <tj@kernel.org>
tools/testing/selftests/cgroup/lib/cgroup_util.c