]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
efi/cper: Fix cper_bits_to_str buffer handling and return value
authorMorduan Zang <zhangdandan@uniontech.com>
Wed, 14 Jan 2026 05:30:33 +0000 (13:30 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 6 Feb 2026 15:43:53 +0000 (16:43 +0100)
commite7655cd37d17a50048cf799d788288e15cdaf8db
tree1dbe3adcf41118d181176c985ec037b99907adfc
parentcc946fb786420cf3c3cf93137e08911eef2650f1
efi/cper: Fix cper_bits_to_str buffer handling and return value

commit d7f1b4bdc7108be1b178e1617b5f45c8918e88d7 upstream.

The return value calculation was incorrect: `return len - buf_size;`
Initially `len = buf_size`, then `len` decreases with each operation.
This results in a negative return value on success.

Fix by returning `buf_size - len` which correctly calculates the actual
number of bytes written.

Fixes: a976d790f494 ("efi/cper: Add a new helper function to print bitmasks")
Signed-off-by: Morduan Zang <zhangdandan@uniontech.com>
Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/firmware/efi/cper.c