]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
fs/ntfs3: call _ntfs_bad_inode() when failing to rename
authorHelen Koike <koike@igalia.com>
Wed, 6 May 2026 17:08:22 +0000 (14:08 -0300)
committerKonstantin Komarov <almaz.alexandrovich@paragon-software.com>
Tue, 2 Jun 2026 15:02:29 +0000 (17:02 +0200)
commite8ed78f40eecd0176fda71d673f6957c98e7ffbe
tree3085ca8734cadb636cf4eb67af343c370e878a7e
parent36c7276816ed4266c155b71b1fa747b2785f23f7
fs/ntfs3: call _ntfs_bad_inode() when failing to rename

It is safe to call _ntfs_bad_inode on live inodes since:
  commit 519b078998ce ("fs/ntfs3: Exclude call make_bad_inode for live nodes.")

The WARN_ON was added when it wasn't safe by:
  commit d99208b91933 ("fs/ntfs3: cancle set bad inode after removing name fails")

Replace the WARN_ON with a call to _ntfs_bad_inode() to prevent further
operations on the inconsistent inode.

Reported-by: syzbot+4d8e30dbafb5c1260479@syzkaller.appspotmail.com
Closes: https://syzkaller.appspot.com/bug?extid=4d8e30dbafb5c1260479
Fixes: 519b078998ce ("fs/ntfs3: Exclude call make_bad_inode for live nodes.")
Signed-off-by: Helen Koike <koike@igalia.com>
Signed-off-by: Konstantin Komarov <almaz.alexandrovich@paragon-software.com>
fs/ntfs3/frecord.c