]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
blk-wbt: remove WARN_ON_ONCE from wbt_init_enable_default()
authorYuto Ohnuki <ytohnuki@amazon.com>
Mon, 16 Mar 2026 07:03:59 +0000 (07:03 +0000)
committerJens Axboe <axboe@kernel.dk>
Mon, 6 Apr 2026 18:54:03 +0000 (12:54 -0600)
commite9b004ff83067cdf96774b45aea4b239ace99a2f
tree46f86d5b2d052c4bbbdefc3c693c13d781c7f96b
parent320f9b1c6a942a73c26be56742ee1da04f893a4f
blk-wbt: remove WARN_ON_ONCE from wbt_init_enable_default()

wbt_init_enable_default() uses WARN_ON_ONCE to check for failures from
wbt_alloc() and wbt_init(). However, both are expected failure paths:

- wbt_alloc() can return NULL under memory pressure (-ENOMEM)
- wbt_init() can fail with -EBUSY if wbt is already registered

syzbot triggers this by injecting memory allocation failures during MTD
partition creation via ioctl(BLKPG), causing a spurious warning.

wbt_init_enable_default() is a best-effort initialization called from
blk_register_queue() with a void return type. Failure simply means the
disk operates without writeback throttling, which is harmless.

Replace WARN_ON_ONCE with plain if-checks, consistent with how
wbt_set_lat() in the same file already handles these failures. Add a
pr_warn() for the wbt_init() failure to retain diagnostic information
without triggering a full stack trace.

Reported-by: syzbot+71fcf20f7c1e5043d78c@syzkaller.appspotmail.com
Closes: https://syzkaller.appspot.com/bug?extid=71fcf20f7c1e5043d78c
Fixes: 41afaeeda509 ("blk-wbt: fix possible deadlock to nest pcpu_alloc_mutex under q_usage_counter")
Signed-off-by: Yuto Ohnuki <ytohnuki@amazon.com>
Reviewed-by: Yu Kuai <yukuai@fnnas.com>
Reviewed-by: Nilay Shroff <nilay@linux.ibm.com>
Link: https://patch.msgid.link/20260316070358.65225-2-ytohnuki@amazon.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
block/blk-wbt.c