]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
netfilter: nf_conntrack_sip: get helper before allocating expectation
authorLi Xiasong <lixiasong1@huawei.com>
Thu, 7 May 2026 14:04:22 +0000 (22:04 +0800)
committerPablo Neira Ayuso <pablo@netfilter.org>
Thu, 7 May 2026 23:30:17 +0000 (01:30 +0200)
commiteb6317739b1ea3ab28791e1f91b24781905fa815
treeca7207eda2b5ab5f8d0431b261e3bd552895e3dc
parentd8ef54c83ad70b81735b506431affadd2f720aa1
netfilter: nf_conntrack_sip: get helper before allocating expectation

process_register_request() allocates an expectation and then checks
whether a conntrack helper is available. If helper lookup fails, the
function returns early and the allocated expectation is left behind.

Reorder the code to fetch and validate helper before calling
nf_ct_expect_alloc(). This keeps the logic simpler and removes the leak
path while preserving existing behavior.

Fixes: e14575fa7529 ("netfilter: nf_conntrack: use rcu accessors where needed")
Cc: stable@vger.kernel.org
Signed-off-by: Li Xiasong <lixiasong1@huawei.com>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
net/netfilter/nf_conntrack_sip.c