]> git.ipfire.org Git - thirdparty/linux.git/commit
enic: fix tx_hang_reset use-after-free on device removal
authorSatish Kharat <satishkh@cisco.com>
Tue, 28 Jul 2026 06:26:30 +0000 (23:26 -0700)
committerJakub Kicinski <kuba@kernel.org>
Thu, 30 Jul 2026 23:41:22 +0000 (16:41 -0700)
commitec680ea4ba1bca92a767fb7e7869758bfdd886e3
tree1c0507ad0bd4d8888812061611c2196e4a87dc05
parentc2707480cfbf19c7619acc9c089d17f20869821f
enic: fix tx_hang_reset use-after-free on device removal

enic_remove() cancels the reset and change_mtu_work items but does not
cancel tx_hang_reset. A TX timeout that fires while the device is being
removed can schedule enic_tx_hang_reset() so that it runs after
free_netdev(), resulting in a use-after-free.

cancel_work_sync() alone is not sufficient here: the still-live watchdog
and notify paths can re-schedule these work items in the window between
the cancel and unregister_netdev(). Use disable_work_sync(), which
cancels the work and blocks any subsequent schedule_work() from
requeuing it, and apply it to the reset and change_mtu_work items as
well so the same requeue race is closed for all teardown work.

Fixes: 937317c7c109 ("enic: do hang reset only in case of tx timeout")
Signed-off-by: Satish Kharat <satishkh@cisco.com>
Link: https://patch.msgid.link/20260728062730.2394873-1-satishkh@cisco.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/cisco/enic/enic_main.c